ActiveState Community

Possible Bug: Macro does not work when invoked from the Tool menu with mouse, but does work when invoked via key binding

Posted by dreftymac on 2008-12-31 23:47
OS: Windows XP Pro

Problem: I have a macro that works when run from a
custom keybinding but it does not work when run from
the Tool menu.

komodo.view.setFocus();
komodo.doCommand('cmd_focusEditor');    /// added in just to be extra sure
komodo.doCommand('cmd_selectWordLeft'); /// this NO_WORKY

The specific part that fails is cmd_selectWordLeft.

Question: Is there a way to ensure that macro commands
will *always* work regardless of what context the user
chooses to invoke them from?

answered after more web searching
dreftymac | Thu, 2009-01-01 07:42

There are currently some issues with komodo.docommand and some commands. To work around this, change this line:

komodo.doCommand("cmd_selectWordLeft");

to this instead:

komodo.editor.wordLeftExtend();

Posted by: jeffg | April 18, 2006 at 10:37 PM

(http://blogs.activestate.com/jeffg/2005/09/komodo_hacks_pa.html)

You're right, in general it's better to use the Komodo API
ericp | Tue, 2009-01-06 14:45

I've spent some time trying to fix this, and here's the problem:

Each of the Komodo "cmd_*" commands execute inside a particular
"controller". When you've created a macro, the controller is
associated with the editor view. But when you save the macro
in a toolbox, it executes in that project's controller, and
it can't figure out how to get to the editor.

I suppose we could fix this, but in general it's better
to try to move your macros from using the Komodo commands
to working with the Komodo API more directly. Which is
what you did above, after whatever googling finding the
fix required.

- Eric

I did this and all macros are working from Tools menu
gatavas | Thu, 2009-01-22 10:30

//if (komodo.view) { komodo.view.setFocus() };
if (komodo.view.scintilla) { komodo.view.scintilla.focus(); }

This is covered in bug 53647
ericp | Thu, 2009-01-22 11:48

... and some duplicates. Todd figured out the solution a while
ago, but his change didn't get released. Nice work.

Ref: http://bugs.activestate.com/show_bug.cgi?id=53647

If you want to patch it, you'll need to dig macros.js out of komodo.jar,
and apply this patch:

Index: src/chrome/komodo/content/library/macros.js
===================================================================
--- src/chrome/komodo/content/library/macros.js (revision 25990)
+++ src/chrome/komodo/content/library/macros.js (working copy)
@@ -35,7 +35,7 @@
         this._currentMacro.push("// Macro recorded on " + Date() + '\n');
         var macroVersionNumber = "2"; // must match the number in peMacro.js
         this._currentMacro.push('komodo.assertMacroVersion(' + macroVersionNumber + ');\n');
-        this._currentMacro.push("if (komodo.view) { komodo.view.setFocus() };\n");
+        this._currentMacro.push("if (komodo.view && komodo.view.scintilla) { komodo.view.scintilla.focus(); }\n");
         this._currentMacroText = new Array();
     }
     this.mode = 'recording';
Index: src/chrome/komodo/content/library/macros.js
===================================================================
--- src/chrome/komodo/content/library/macros.js (revision 25990)
+++ src/chrome/komodo/content/library/macros.js (working copy)
@@ -35,7 +35,7 @@
         this._currentMacro.push("// Macro recorded on " + Date() + '\n');
         var macroVersionNumber = "2"; // must match the number in peMacro.js
         this._currentMacro.push('komodo.assertMacroVersion(' + macroVersionNumber + ');\n');
-        this._currentMacro.push("if (komodo.view) { komodo.view.setFocus() };\n");
+        this._currentMacro.push("if (komodo.view && komodo.view.scintilla) { komodo.view.scintilla.focus(); }\n");
         this._currentMacroText = new Array();
     }
     this.mode = 'recording';