ActiveState Community Site - PL/SQL Code Intelligence - Comments

The folding is another bug

ericp — Fri, 09 May 2008 10:34:53 -0700

I looked at the lexer, and it looks like it's making the right noises about
supporting folding. Then I had a look at the language service file
koSQLLanguage.py, and saw this line:

self._lexer.supportsFolding = 0

I changed the '0' to a '1', restarted Komodo, and it's folding fine.

Instabug at http://bugs.activestate.com/show_bug.cgi?id=76875

Code completion

gsalem — Fri, 09 May 2008 01:02:32 -0700

Hi,
it would be very nice to have, although not a big issue. What would be much better is code folding. I started looking at other .py to see how it can be done. Surely you're more knowledgeable than myself to do it. But if I can help in any way, just drop me a note.

Thanks again

Just to wrap up this thread...

ericp — Thu, 08 May 2008 14:21:09 -0700

GSalem tested the new koSQLLanguage.py module, and reports that it's working fine.
I have to admit that we in the Komodo group don't have much experience with
Oracle. MySQL, Postgres, SQLite, and even ODBC/Access, yes. We figured that
the PL-SQL module was working fine in the field, since no one had complained.
After a quick look, I saw it was flawed, and not just in the way it's missing
a few hundred keywords.

We'll be shipping the fixed version in the next alpha of Komodo 4.4, both IDE
and Edit.

As for the question about code-completion that started this discussion, with
over 1100 keywords in the language, I can see simple three-character completion
like we have for many other languages might deliver enough.

Hmmm, maybe raising that subject doesn't close this thread. Please reply on
other kinds of completion you'd like to see.

no

gsalem — Thu, 08 May 2008 13:18:33 -0700

The question is that there is no need to generate the pyo. And you already answered it.
Thanks a lot

What's the question?

ericp — Thu, 08 May 2008 13:02:51 -0700

It looks like your question was cut off in the title.

- Eric

IT seems there is no need to

gsalem — Thu, 08 May 2008 12:58:00 -0700

Am I right?

Let Komodo create the .pyo files

ericp — Thu, 08 May 2008 12:51:25 -0700

There are problems with the existing koSQLLanguage.py file:

There is no extension for PL/SQL files. I've added "*.plsql"

There is no color scheme at all for PL/SQL files. I've
refactored the class so *.sql and *.plsql files share the
same scheme.

The synonym for "REM" comments wasn't handled, so I added that,
using Scintilla's "InListAbbrev" functionality, so any prefix
of "remark" beginning with "rem" will match, case-insensitively.

gsalem, I'll email you the new koSQLLanguage.py I'm about to check in,
could you tell me if it works?

I modiofied the koSQLanguage.py

gsalem — Thu, 08 May 2008 12:44:51 -0700

but how to make it into a .pyo? if I try python -O it gives an error about not finding module xpcom.

thanks

thanks a lot

gsalem — Thu, 08 May 2008 10:16:22 -0700

It would be very nice of you

I'll add your keywords to the language service for v 4.4

ericp — Thu, 08 May 2008 09:36:49 -0700

Hope you don't feel you spent too much time on UDL.

I'll still look at the file to see if there's a bug
somewhere.

- Eric

I'll look into the standard lexer as you say

gsalem — Thu, 08 May 2008 00:33:36 -0700

I'll try to see if I can "enhance" it with more reserved words.

thanks

Could you elaborate on your question?

ericp — Wed, 07 May 2008 13:00:29 -0700

Which PL-SQL lexer do you mean? The one that ships with Komodo, or the one
that gsalem wrote?

I'm not an expert on SQL, but my understanding is that there's a core
set of keywords, and then each vendor has extended the language in
their own way. Could you list any keywords that are missing?

It's easy for us to ship a proper set of keywords. I've created
a public bug at http://bugs.activestate.com/show_bug.cgi?id=76743

Another advantage of going with the existing lexer: it handles case-insensitivity
of keywords, but UDL only does case-sensitive keywords.

Is there a good reason why

davitof — Wed, 07 May 2008 11:59:17 -0700

Is there a good reason why the PL-SQL lexer behaved as a test lexer for my SQL script? I thought a PL-SQL lexer should recognize the standard SQL keywords.

Thanks

davitof — Wed, 07 May 2008 11:55:43 -0700

Thanks

Got the UDL file, I'll have a look at it

ericp — Wed, 07 May 2008 10:49:28 -0700

The "PL/SQL" support that ships with Komodo is a combination of
the LexSQL.cxx lexer that comes with Scintilla, and the
koSQLLanguage.py language service that we wrote (and you can find
in /lib/mozilla/components/koSQLLanguage.py).

I'm only looking at the source, but
it looks like it does folding on comments, ( ... ), and the BEGIN/
LOOP/IF ... END constructs. If the main difference is that you
want it to handle the extra keywords, you can add them to
the list of keywords in class koSQLLanguage.py::koPLSQLLanguage
-- watch out, this file defines classes for both koSQLLanguage
and koPLSQLLanguage.

I will have a look at the UDL file, as I'm curious whether the
problem is in the UDL itself or the engine, but it seems to me
that we should add this list of keywords to the existing
language service.

Is there anything else you're looking for in PL/SQL editing?

Thanks,
Eric

PL/SQL Code Intelligence

gsalem — Mon, 14 Jan 2008 15:05:52 -0800

Hi all,
Is there any way to get the udl files used to build SQL and PL/SQL code intel? I use PL/SQL a lot and would like to enhance the CI's support for it (and for sure give back to the community)?

Many thanks